Repository navigation
Allow named views and indexing with a subset of a tensor's indices - #266
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
+ Coverage 77.62% 77.69% +0.06%
==========================================
Files 30 30
Lines 1819 1820 +1
==========================================
+ Hits 1412 1414 +2
+ Misses 407 406 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mtfishman
reviewed
Sep 30, 2026
Member
|
This is clever, I hadn't considered this syntax... I'll merge once tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking views of tensors with a subset of said tensors indices, i.e.
view(a, j[2:3]) or a[j => 2:3], used to throwMethodError: no method matching isless(::Int64, ::Nothing). It now slices the array dimensions corresponding to the provided named indices, and keeps the others whole. A scalar named index drops its dimension in the same way that unnamed scalar indexing does.An index provided that is not in the tensor, or the same index given more than once, now throws
NameMismatch. These cases threw the same confusingMethodErrorbefore, so it should now also be clearer to users when these invalid inputs are given.